linux-kernel - Re: [PATCH net v3 2/3] selftest/bpf: Add test for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67a1ae27-84c1-4a5c-9178-a29276d6ab52@rbox.co>
Date: Mon, 17 Mar 2025 10:51:37 +0100
From: Michal Luczaj <mhal@...x.co>
To: Paolo Abeni <pabeni@...hat.com>, Stefano Garzarella
 <sgarzare@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>,
 Bobby Eshleman <bobby.eshleman@...edance.com>,
 Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>,
 Mykola Lysenko <mykolal@...com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Shuah Khan <shuah@...nel.org>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
 virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net v3 2/3] selftest/bpf: Add test for AF_VSOCK connect()
 racing sockmap update

On 3/17/25 09:23, Paolo Abeni wrote:
> On 3/16/25 11:45 PM, Michal Luczaj wrote:
>> Racing signal-interrupted connect() and sockmap update may result in an
>> unconnected (and missing vsock transport) socket in a sockmap.
>>
>> Test spends 2 seconds attempting to reach WARN_ON_ONCE().
>>
>> connect
>>   / state = SS_CONNECTED /
>>                                 sock_map_update_elem
>>   if signal_pending
>>     state = SS_UNCONNECTED
>>
>> connect
>>   transport = NULL
>>                                 vsock_bpf_recvmsg
>>                                   WARN_ON_ONCE(!vsk->transport)
>>
>> Signed-off-by: Michal Luczaj <mhal@...x.co>
> 
> This is apparently causing some bpf self-test failure. (Timeout? the
> self-test failure output is not clear to me.)
> 
> Could you please have a look?

Sending signal to the whole process group probably isn't the best idea. Not
sure how the previous version passed though.
Sorry, v4 incoming.

Michal