linux-kernel - Re: [PATCH v2] RDMA/erdma: Fix exception handling in erdma_accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67a12e7e-51ff-36bf-a575-b77c09b56110@linux.alibaba.com>
Date: Mon, 17 Mar 2025 10:27:32 +0800
From: Cheng Xu <chengyou@...ux.alibaba.com>
To: Markus Elfring <Markus.Elfring@....de>, linux-rdma@...r.kernel.org,
 Jason Gunthorpe <jgg@...pe.ca>, Kai Shen <kaishen@...ux.alibaba.com>,
 Leon Romanovsky <leon@...nel.org>, Yang Li <yang.lee@...ux.alibaba.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] RDMA/erdma: Fix exception handling in
 erdma_accept_newconn()



On 3/13/25 8:10 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 13 Mar 2025 11:44:50 +0100
> 
> The label “error” was used to jump to another pointer check despite of
> the detail in the implementation of the function “erdma_accept_newconn”
> that it was determined already that corresponding variables contained
> still null pointers.
> 
> 1. Thus return directly if
>    * the cep state is not the value “ERDMA_EPSTATE_LISTENING”
>      or
>    * a call of the function “erdma_cep_alloc” failed.
> 
> 2. Use more appropriate labels instead.
> 
> 3. Delete two questionable checks.
> 
> 4. Omit extra initialisations (for the variables “new_cep”, “new_s” and “ret”)
>    which became unnecessary with this refactoring.
> 
> 
> This issue was detected by using the Coccinelle software.
> 
> Fixes: 920d93eac8b9 ("RDMA/erdma: Add connection management (CM) support")


I think this patch does not fix issues, so fix line is not needed.

Thanks,
Cheng Xu


> Cc: stable@...r.kernel.org
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---

<...>