linux-kernel - Re: [PATCH] drm/panel/synaptics-r63353: Use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <78758343-b9f9-4920-977c-cab4b5f84679@linaro.org>
Date: Mon, 17 Mar 2025 11:14:13 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Anusha Srivatsa <asrivats@...hat.com>,
 Doug Anderson <dianders@...omium.org>
Cc: Michael Trimarchi <michael@...rulasolutions.com>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Tejas Vipin <tejasvipin76@...il.com>
Subject: Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

On 16/03/2025 18:40, Anusha Srivatsa wrote:
> 
> 
> On Fri, Mar 14, 2025 at 10:20 AM Doug Anderson <dianders@...omium.org <mailto:dianders@...omium.org>> wrote:
> 
>     Hi,
> 
>     On Thu, Mar 13, 2025 at 9:47 PM Anusha Srivatsa <asrivats@...hat.com <mailto:asrivats@...hat.com>> wrote:
>      >
>      > @@ -181,24 +162,15 @@ static int r63353_panel_prepare(struct drm_panel *panel)
>      >  static int r63353_panel_deactivate(struct r63353_panel *rpanel)
>      >  {
>      >         struct mipi_dsi_device *dsi = rpanel->dsi;
>      > -       struct device *dev = &dsi->dev;
>      > -       int ret;
>      > +       struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>      >
>      > -       ret = mipi_dsi_dcs_set_display_off(dsi);
>      > -       if (ret < 0) {
>      > -               dev_err(dev, "Failed to set display OFF (%d)\n", ret);
>      > -               return ret;
>      > -       }
>      > +       mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>      >
>      > -       usleep_range(5000, 10000);
>      > +       mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000);
>      >
>      > -       ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
>      > -       if (ret < 0) {
>      > -               dev_err(dev, "Failed to enter sleep mode (%d)\n", ret);
>      > -               return ret;
>      > -       }
>      > +       mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
>      >
>      > -       return 0;
>      > +       return dsi_ctx.accum_err;
> 
>     nit: the one caller of r63353_panel_deactivate() doesn't actually look
>     at the error code, so this could be a function that returns "void".
>     That was true even before your patch, though. I wouldn't mind a
>     followup patch that fixed this. ;-)
> 
> 
> This is anyway not merged, Maybe better to fix right now instead of a follow up patch?

If you can, yeah fix it now !

> 
>     In any case, the patch looks reasonable to me now.
> 
>     Reviewed-by: Douglas Anderson <dianders@...omium.org <mailto:dianders@...omium.org>>
> 
> 
> Thanks :)
> 
> Anusha


Thanks,
Neil
> 
> 
>     Happy for someone else to apply it if they want. If not, I'll snooze
>     this for ~a week to give others a chance to comment and then plan to
>     push to drm-misc-next. 
> 
> 
> 
>     -Doug
>