linux-kernel - [tip: sched/core] sched/topology: Remove redundant dl_clear_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <174220767961.14745.14327073917316253565.tip-bot2@tip-bot2>
Date: Mon, 17 Mar 2025 10:34:39 -0000
From: "tip-bot2 for Juri Lelli" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Juri Lelli <juri.lelli@...hat.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Waiman Long <llong@...hat.com>, Shrikanth Hegde <sshegde@...ux.ibm.com>,
 Valentin Schneider <vschneid@...hat.com>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Waiman Long <longman@...hat.com>,
 Jon Hunter <jonathanh@...dia.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject:
 [tip: sched/core] sched/topology: Remove redundant dl_clear_root_domain call

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     d735bab3d58c4c96e67037490d19d35392065da9
Gitweb:        https://git.kernel.org/tip/d735bab3d58c4c96e67037490d19d35392065da9
Author:        Juri Lelli <juri.lelli@...hat.com>
AuthorDate:    Thu, 13 Mar 2025 18:11:17 +01:00
Committer:     Peter Zijlstra <peterz@...radead.org>
CommitterDate: Mon, 17 Mar 2025 11:23:42 +01:00

sched/topology: Remove redundant dl_clear_root_domain call

We completely clean and restore root domains bandwidth accounting after
every root domains change, so the dl_clear_root_domain() call in
partition_sched_domains_locked() is redundant.

Remove it.

Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Reviewed-by: Waiman Long <llong@...hat.com>
Reviewed-by: Shrikanth Hegde <sshegde@...ux.ibm.com>
Reviewed-by: Valentin Schneider <vschneid@...hat.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com>
Tested-by: Waiman Long <longman@...hat.com>
Tested-by: Jon Hunter <jonathanh@...dia.com>
Tested-by: Dietmar Eggemann <dietmar.eggemann@....com>
Link: https://lore.kernel.org/r/Z9MRtcX4tz4tcLRR@jlelli-thinkpadt14gen4.remote.csb
---
 kernel/sched/topology.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 363ad26..df2d94a 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -2720,21 +2720,8 @@ void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
 	for (i = 0; i < ndoms_cur; i++) {
 		for (j = 0; j < n && !new_topology; j++) {
 			if (cpumask_equal(doms_cur[i], doms_new[j]) &&
-			    dattrs_equal(dattr_cur, i, dattr_new, j)) {
-				struct root_domain *rd;
-
-				/*
-				 * This domain won't be destroyed and as such
-				 * its dl_bw->total_bw needs to be cleared.
-				 * Tasks contribution will be then recomputed
-				 * in function dl_update_tasks_root_domain(),
-				 * dl_servers contribution in function
-				 * dl_restore_server_root_domain().
-				 */
-				rd = cpu_rq(cpumask_any(doms_cur[i]))->rd;
-				dl_clear_root_domain(rd);
+			    dattrs_equal(dattr_cur, i, dattr_new, j))
 				goto match1;
-			}
 		}
 		/* No match - a current sched domain not in new doms_new[] */
 		detach_destroy_domains(doms_cur[i]);