linux-kernel - Re: [PATCH v2] media: dt-bindings: Convert Analog Devices ad5820 to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250317-impartial-lobster-of-karma-b38fd0@krzk-bin>
Date: Mon, 17 Mar 2025 11:37:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Pavel Machek <pavel@....cz>, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: dt-bindings: Convert Analog Devices ad5820 to
 DT schema

On Fri, Mar 14, 2025 at 08:58:27PM +0100, David Heidelberg wrote:
> Convert the Analog Devices ad5820 to DT schema format.
> 
> Add the previously undocumented io-channel-cells property,

You did not explain here *why* you added this property. Your patch, your
changes, anything should say why you are doing it.

> which can be omitted. If present, it must be set to 0,
> as the device provides only one channel.

Also, Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> Changes in v2:
> - added MAINTAINERS entry for the binding
> - documented why io-channel-cells got added into the binding.
> - dropped io-channel-cells in required properties.
> - adjusted example indentation to 4 spaces.
> - Link to v1: https://lore.kernel.org/r/20250209203940.159088-1-david@ixit.cz

Best regards,
Krzysztof