linux-kernel - Re: [PATCH v4 2/3] arm64: dts: amlogic: Add A4 Reset Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dceafbf-49d4-4084-bfae-74384e187941@amlogic.com>
Date: Mon, 17 Mar 2025 10:49:52 +0800
From: Kelvin Zhang <kelvin.zhang@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman
	<khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, "Martin
 Blumenstingl" <martin.blumenstingl@...glemail.com>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-amlogic@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, "Zelong
 Dong" <zelong.dong@...ogic.com>
Subject: Re: [PATCH v4 2/3] arm64: dts: amlogic: Add A4 Reset Controller

On 2025/3/14 16:01, Krzysztof Kozlowski wrote:
> 
> On Thu, Mar 13, 2025 at 05:05:35PM +0800, Kelvin Zhang wrote:
>>   &apb {
>> +     reset: reset-controller@...0 {
>> +             compatible = "amlogic,a4-reset",
>> +                          "amlogic,meson-s4-reset";
>> +             reg = <0x0 0x2000 0x0 0x98>;
>> +             #reset-cells = <1>;
>> +     };
>> +
> 
> Why do you have on the bus devices with bus addressing and without it?
> What sort of bus is it?

Are you referring to the 'apb'?
If so, the 'apb' bus is defined in 
arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi.

apb: bus@...00000 {
         compatible = "simple-bus";
         reg = <0x0 0xfe000000 0x0 0x480000>;
         #address-cells = <2>;
         #size-cells = <2>;
         ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;

> 
>>        periphs_pinctrl: pinctrl {
>>                compatible = "amlogic,pinctrl-a4";
>>                #address-cells = <2>;
> 
> Best regards,
> Krzysztof
> 

-- 
Best regards,

Kelvin Zhang