linux-kernel - Re: [PATCH 1/3] dt-bindings: iio: light: veml6046x00: add color sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42685f01-d864-4e68-913a-49bdb6337581@kernel.org>
Date: Mon, 17 Mar 2025 12:26:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andreas Klinger <ak@...klinger.de>, Jonathan Cameron <jic23@...nel.org>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 lars@...afoo.de, linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, javier.carrasco.cruz@...il.com,
 mazziesaccount@...il.com, subhajit.ghosh@...aklogic.com,
 muditsharma.info@...il.com, arthur.becker@...tec.com,
 ivan.orlov0322@...il.com
Subject: Re: [PATCH 1/3] dt-bindings: iio: light: veml6046x00: add color
 sensor

On 17/03/2025 12:17, Andreas Klinger wrote:
>>> +  - |
>>> +    i2c {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        color-sensor@29 {
>>> +            compatible = "vishay,veml6046x00";
>>> +            reg = <0x29>;
>>> +            vdd-supply = <&vdd_reg>;
>>> +            interrupt-parent = <&gpio2>;
>>> +            interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
>> Need an include for this I think.  Make sure to test build your
>> bindings following the instructions in the bot message.
> 
> I already sent out an version 2 yesterday which is with the include, tested and
> already reviewed by Krzysztof.

The point is that you should test it, not rely on us and our tools (e.g.
my or Rob's machine). If our tools report such issues, it is already too
late because it means you did not follow the process.

Best regards,
Krzysztof