linux-kernel - 回覆: [net-next 4/4] net: ftgmac100: add RGMII delay for AST2600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51347CD1AB5940641A77427D9DDF2@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Mon, 17 Mar 2025 11:33:01 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Russell King <linux@...linux.org.uk>, Maxime Chevallier
	<maxime.chevallier@...tlin.com>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "ratbert@...aday-tech.com"
	<ratbert@...aday-tech.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject:
 回覆: [net-next 4/4] net: ftgmac100: add RGMII delay for AST2600

> > So this goes completely against the naming of the property. It has the
> > -ps suffix, so you would expect to have picoseconds values passed, and
> > not an arbiraty index.
> >
> > Take a look at other drivers, you should accept picseconds values from
> > these properties, then compute the relevant index in the driver. That
> > index should be something internal to your driver.
> >
> > An example here :
> >
> > https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/net/ethernet
> > /microchip/sparx5/lan969x/lan969x_rgmii.c#L51
> 
> Another example would be drivers/net/phy/adin.c::adin_get_reg_value()
> and associated functions - these lookup a DT property and then look that up in
> a table to convert it to a register value.
> 
> I suspect that's something which could become generic, as I suspect most
> hardware isn't going to accept a picosecond value, but be a choice of N
> different options.

Thank you for your information.
The RGMII delay of AST2600 has a lot of steps can be configured.
And the delay value of each MAC has different.
Each MAC has 64 steps to configure RGMII TX/RX delay.
Therefore, I use these properties as index to configure the register to reduce 
computing in driver.
Or I do not use the property that defined in ethernet-controller.yaml, I 
create the property that defined by myself?

Thanks,
Jacky