linux-kernel - Re: [PATCH 2/7] coresight: Convert disclaim functions to take a struct cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6a86373-64be-4101-a08a-74aa302bf64c@linaro.org>
Date: Mon, 17 Mar 2025 11:36:40 +0000
From: James Clark <james.clark@...aro.org>
To: Leo Yan <leo.yan@....com>
Cc: lcherian@...vell.com, coresight@...ts.linaro.org,
 Mike Leach <mike.leach@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 2/7] coresight: Convert disclaim functions to take a
 struct cs_access



On 13/03/2025 2:54 pm, Leo Yan wrote:
> On Tue, Feb 11, 2025 at 10:39:38AM +0000, James Clark wrote:
> 
> [...]
> 
>>   static inline bool coresight_is_claimed_any(struct coresight_device *csdev)
>>   {
>> -       return coresight_read_claim_tags(csdev) != 0;
>> +       return coresight_read_claim_tags(&csdev->access) != 0;
>>   }
> 
> Likewise other claim functions, can coresight_is_claimed_any() change its
> argument type from struct coresight_device to struct csdev_access?
> 
> Thanks,
> Leo

I only wanted to change the ones that I had to. I think we should 
prioritize passing csdev as much as possible in the coresight framework 
to make everything consistent. Otherwise it's extra churn for no 
benefit, and if we need something from csdev here in the future we'll 
have to change this one back again.