linux-kernel - Re: [PATCH 08/13] objtool: Upgrade "Linked object detected" warning to error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2503171337440.4236@pobox.suse.cz>
Date: Mon, 17 Mar 2025 13:38:22 +0100 (CET)
From: Miroslav Benes <mbenes@...e.cz>
To: Josh Poimboeuf <jpoimboe@...nel.org>
cc: x86@...nel.org, linux-kernel@...r.kernel.org, 
    Peter Zijlstra <peterz@...radead.org>, 
    Brendan Jackman <jackmanb@...gle.com>, 
    Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 08/13] objtool: Upgrade "Linked object detected" warning
 to error

Hi,

On Fri, 14 Mar 2025, Josh Poimboeuf wrote:

> Force the user to fix their cmdline if they forget the '--link' option.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
> ---
>  tools/objtool/builtin-check.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
> index 36d81a455b01..79843512a51b 100644
> --- a/tools/objtool/builtin-check.c
> +++ b/tools/objtool/builtin-check.c
> @@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv)
>  		return 1;
>  
>  	if (!opts.link && has_multiple_files(file->elf)) {
> -		ERROR("Linked object detected, forcing --link");
> -		opts.link = true;
> +		ERROR("Linked object requires --link");
> +		goto err;

there is no 'err' label in objtool_run() at this point. It is introduced 
by the next patch.

Miroslav