linux-kernel - Re: [PATCH linux-next] selinux: avc: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEjxPJ73QGRoG8VKV+T+cohz1f05QB5iQ3DhuvHSnSJtEYx0xg@mail.gmail.com>
Date: Mon, 17 Mar 2025 08:41:05 -0400
From: Stephen Smalley <stephen.smalley.work@...il.com>
To: xie.ludan@....com.cn
Cc: paul@...l-moore.com, omosnace@...hat.com, selinux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] selinux: avc: use sysfs_emit() instead of scnprintf()

On Sat, Mar 15, 2025 at 2:12 AM <xie.ludan@....com.cn> wrote:
>
> From: XieLudan <xie.ludan@....com.cn>
>
>
> Follow the advice in Documentation/filesystems/sysfs.rst:
>
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
>
> the value to be returned to user space.
>
>
> Signed-off-by: XieLudan <xie.ludan@....com.cn>

NAK.
Despite being mounted under /sys, selinuxfs is its own pseudo
filesystem and thus shouldn't use sysfs functions.

>
> ---
>
>  security/selinux/avc.c | 2 +-
>
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
>
> index 4b4837a20225..007bd94975c0 100644
>
> --- a/security/selinux/avc.c
>
> +++ b/security/selinux/avc.c
>
> @@ -164,7 +164,7 @@ int avc_get_hash_stats(char *page)
>
>
>
>   rcu_read_unlock();
>
>
>
> - return scnprintf(page, PAGE_SIZE, "entries: %d\nbuckets used: %d/%d\n"
>
> + return sysfs_emit(page, "entries: %d\nbuckets used: %d/%d\n"
>
>   "longest chain: %d\n",
>
>   atomic_read(&selinux_avc.avc_cache.active_nodes),
>
>   slots_used, AVC_CACHE_SLOTS, max_chain_len);
>
> --
>
> 2.25.1
>
>
>
>
>