linux-kernel - Re: [PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025031834-spotty-dipped-be36@gregkh>
Date: Tue, 18 Mar 2025 14:24:01 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Huacai Chen <chenhuacai@...ngson.cn>
Cc: Sasha Levin <sashal@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
	Xuerui Wang <kernel@...0n.name>, stable@...r.kernel.org,
	David Howells <dhowells@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Jan Stancek <jstancek@...hat.com>,
	Jarkko Sakkinen <jarkko@...nel.org>, keyrings@...r.kernel.org,
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
	R Nageswara Sastry <rnsastry@...ux.ibm.com>,
	Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL
 helper functions to a header

On Tue, Mar 18, 2025 at 07:01:22PM +0800, Huacai Chen wrote:
> From: Jan Stancek <jstancek@...hat.com>
> 
> commit 300e6d4116f956b035281ec94297dc4dc8d4e1d3 upstream.
> 
> Couple error handling helpers are repeated in both tools, so
> move them to a common header.
> 
> Signed-off-by: Jan Stancek <jstancek@...hat.com>
> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> Tested-by: R Nageswara Sastry <rnsastry@...ux.ibm.com>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---

Is this "v2" as well?  the threading is all confusing here.  This is
what my inbox looks like right now:


  32 N T Mar 18 Huacai Chen     (2.9K) [PATCH 6.1&6.6 V2 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0
  33 N T Mar 18 Huacai Chen     (7.9K) ├─>[PATCH 6.1&6.6 V2 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3
  34 N T Mar 18 Huacai Chen     (3.4K) ├─>[PATCH 6.1&6.6 V2 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line()
  35 N T Mar 18 Huacai Chen     (4.8K) └─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header
  46 N T Mar 18 Huacai Chen     (2.9K) [PATCH 6.1&6.6 0/3] sign-file,extract-cert: switch to PROVIDER API for OpenSSL >= 3.0
  47 N T Mar 18 Huacai Chen     (3.3K) ├─>[PATCH 6.1&6.6 2/3] sign-file,extract-cert: avoid using deprecated ERR_get_error_line()
  48 N T Mar 18 Huacai Chen     (4.8K) ├─>[PATCH 6.1&6.6 1/3] sign-file,extract-cert: move common SSL helper functions to a header
  50 N T Mar 18 Huacai Chen     (7.8K) └─>[PATCH 6.1&6.6 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3

What would you do if you saw that?

greg k-h