linux-kernel - Re: [PATCH] keys: Fix UAF in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2526768.1742304474@warthog.procyon.org.uk>
Date: Tue, 18 Mar 2025 13:27:54 +0000
From: David Howells <dhowells@...hat.com>
To: Oleg Nesterov <oleg@...hat.com>
Cc: dhowells@...hat.com, Jarkko Sakkinen <jarkko@...nel.org>,
    Kees Cook <kees@...nel.org>, Greg KH <gregkh@...uxfoundation.org>,
    Josh Drake <josh@...phoslabs.com>,
    Suraj Sonawane <surajsonawane0215@...il.com>,
    keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
    security@...nel.org, stable@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] keys: Fix UAF in key_put()

Oleg Nesterov <oleg@...hat.com> wrote:

> and since key_user_put() takes key_user_lock with irqs enabled,
> key_put()->key_user_put() doesn't look correct...

Meh.  Yeah.  I think it's time to do it the other way (i.e. putting keys to be
destroyed onto an explicit cleanup queue).

David