[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z9l2jeCB4hYiTmHk@lizhi-Precision-Tower-5810>
Date: Tue, 18 Mar 2025 09:35:09 -0400
From: Frank Li <Frank.li@....com>
To: Stanley Chu <stanley.chuys@...il.com>
Cc: miquel.raynal@...tlin.com, alexandre.belloni@...tlin.com,
linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
tomer.maimon@...oton.com, kwliu@...oton.com, yschu@...oton.com
Subject: Re: [PATCH v2 3/3] i3c: master: svc: Fix missing STOP for master
request
On Tue, Mar 18, 2025 at 01:36:06PM +0800, Stanley Chu wrote:
> From: Stanley Chu <yschu@...oton.com>
>
> The controller driver nacked the master request but didn't emit a
> STOP to end the transaction. The driver shall refuse the unsupported
> requests and return the controller state to IDLE by emitting a STOP.
>
> Signed-off-by: Stanley Chu <yschu@...oton.com>
Reviewed-by: Frank Li <Frank.Li@....com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 57b9dec6b5a8..e0cd3ce28b7f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
> queue_work(master->base.wq, &master->hj_work);
> break;
> case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST:
> + svc_i3c_master_emit_stop(master);
> default:
> break;
> }
> --
> 2.34.1
>
Powered by blists - more mailing lists