linux-kernel - Re: [PATCH v3] pps: generators: tio: fix platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9l4ktWrZ3VGN8B_@smile.fi.intel.com>
Date: Tue, 18 Mar 2025 15:43:46 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: giometti@...eenne.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pps: generators: tio: fix platform_set_drvdata()

On Tue, Mar 18, 2025 at 05:10:38PM +0530, Raag Jadav wrote:
> platform_set_drvdata() is setting a double pointer to struct pps_tio as
> driver_data, which will point to the local stack of probe function instead
> of intended data. Set driver_data correctly and fix illegal memory access
> by its user.
> 
>  BUG: unable to handle page fault for address: ffffc9000117b738
>  RIP: 0010:hrtimer_active+0x2b/0x60
>  Call Trace:
>   ? hrtimer_active+0x2b/0x60
>   hrtimer_cancel+0x19/0x50
>   pps_gen_tio_remove+0x1e/0x80 [pps_gen_tio]

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko