linux-kernel - Re: [PATCH] regulator: s5m8767: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3abe8cc-357c-471f-b489-e1a8625933e0@kernel.org>
Date: Tue, 18 Mar 2025 14:48:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peng Fan <peng.fan@....com>, Andy Shevchenko
 <andriy.shevchenko@...el.com>, "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: "lgirdwood@...il.com" <lgirdwood@...il.com>,
 "broonie@...nel.org" <broonie@...nel.org>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "brgl@...ev.pl" <brgl@...ev.pl>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] regulator: s5m8767: Convert to GPIO descriptors

On 18/03/2025 13:38, Peng Fan wrote:
>> Also the commit message doesn't tell anything about the existing DTS
>> files.
>> Do we have this device described in any in the kernel? Do we have any
>> googled examples? Why I'm asking because often the issue is the
>> incorrect setting of the polarity, which needs to be carefully checked,
>> esp. for the voltage regulators case.
> 
> 
> Under arch/arm/boot/dts/samsung/, a few dtsi files have the property 
> with results from output of
> `grep "s5m8767" ./arch/arm/boot/dts/samsung/ -rn | grep gpios`
> 
> Exynos5250-spring.dts uses GPIO_ACTIVE_LOW.
> Others use GPIO_ACTIVE_HIGH.
> 
These are old devices and not many people are actually providing tests,
so you need to preserve existing ABI. IOW, if previously GPIO flags were
ignored, meaning "1" is ACTIVE_HIGH, then you must preserve this behavior.

Best regards,
Krzysztof