linux-kernel - Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9mJvh2KGwhOJ6I9@linaro.org>
Date: Tue, 18 Mar 2025 16:57:02 +0200
From: Abel Vesa <abel.vesa@...aro.org>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sibi Sankar <quic_sibis@...cinc.com>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: fix USB retimer reset
 polarity

On 25-03-18 08:49:07, Johan Hovold wrote:
> The ps8830 retimer reset is active low.
> 
> Fix up the retimer nodes which were based on an early version of the
> driver which inverted the polarity.
> 
> Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> Cc: Sibi Sankar <quic_sibis@...cinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

Reviewed-by: Abel Vesa <abel.vesa@...aro.org>

> ---
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> index f92bda2d34f2..dc1a8f5d485a 100644
> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> @@ -788,7 +788,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr2_1p15>;
>  		vddio-supply = <&vreg_rtmr2_1p8>;
>  
> -		reset-gpios = <&tlmm 185 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
>  
>  		orientation-switch;
>  		retimer-switch;
> @@ -843,7 +843,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr0_1p15>;
>  		vddio-supply = <&vreg_rtmr0_1p8>;
>  
> -		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
>  
>  		retimer-switch;
>  		orientation-switch;
> @@ -898,7 +898,7 @@ typec-mux@8 {
>  		vddat-supply = <&vreg_rtmr1_1p15>;
>  		vddio-supply = <&vreg_rtmr1_1p8>;
>  
> -		reset-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&tlmm 176 GPIO_ACTIVE_LOW>;
>  
>  		retimer-switch;
>  		orientation-switch;
> -- 
> 2.48.1
>