| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250318153316.1970147-5-chao.gao@intel.com>
Date: Tue, 18 Mar 2025 23:31:54 +0800
From: Chao Gao <chao.gao@...el.com>
To: x86@...nel.org,
linux-kernel@...r.kernel.org,
kvm@...r.kernel.org,
tglx@...utronix.de,
dave.hansen@...el.com,
seanjc@...gle.com,
pbonzini@...hat.com
Cc: peterz@...radead.org,
rick.p.edgecombe@...el.com,
weijiang.yang@...el.com,
john.allen@....com,
bp@...en8.de,
chang.seok.bae@...el.com,
xin3.li@...el.com,
Chao Gao <chao.gao@...el.com>,
Ingo Molnar <mingo@...hat.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
"H. Peter Anvin" <hpa@...or.com>,
Maxim Levitsky <mlevitsk@...hat.com>,
Mitchell Levy <levymitchell0@...il.com>,
Samuel Holland <samuel.holland@...ive.com>,
Vignesh Balasubramanian <vigbalas@....com>,
Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
Subject: [PATCH v4 4/8] x86/fpu/xstate: Differentiate default features for host and guest FPUs
Currently, guest and host FPUs share the same default features. However,
the CET supervisor xstate is the first feature that needs to be enabled
exclusively for guest FPUs. Enabling it for host FPUs leads to a waste of
24 bytes in the XSAVE buffer.
To support "guest-only" features, introduce two new members,
guest_default_features and guest_default_size, in fpu_kernel_cfg to clearly
differentiate the default features for host and guest FPUs.
An alternative approach is adding a guest_only_xfeatures member to
fpu_kernel_cfg and adding two helper functions to calculate the guest
default xfeatures and size. However, calculating these defaults at runtime
would introduce unnecessary overhead.
Note that, for now, the default features for guest and host FPUs remain the
same. This will change in a follow-up patch once guest permissions, default
xfeatures, and fpstate size are all converted to use the guest defaults.
Signed-off-by: Chao Gao <chao.gao@...el.com>
---
arch/x86/include/asm/fpu/types.h | 20 ++++++++++++++++++++
arch/x86/kernel/fpu/xstate.c | 16 +++++++++++-----
2 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h
index d555f89db42f..80647c060b32 100644
--- a/arch/x86/include/asm/fpu/types.h
+++ b/arch/x86/include/asm/fpu/types.h
@@ -573,6 +573,16 @@ struct fpu_state_config {
*/
unsigned int default_size;
+ /*
+ * @guest_default_size:
+ *
+ * The default size of the register state buffer in guest FPUs.
+ * Includes all supported features except independent managed
+ * features and features which have to be requested by user space
+ * before usage.
+ */
+ unsigned int guest_default_size;
+
/*
* @max_features:
*
@@ -589,6 +599,16 @@ struct fpu_state_config {
* be requested by user space before usage.
*/
u64 default_features;
+
+ /*
+ * @guest_default_features:
+ *
+ * The default supported features bitmap in guest FPUs. Does not
+ * include independent managed features and features which have
+ * to be requested by user space before usage.
+ */
+ u64 guest_default_features;
+
/*
* @legacy_features:
*
diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 14c3a8285f50..1dd6ddba8723 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -673,7 +673,7 @@ static unsigned int __init get_xsave_size_user(void)
static int __init init_xstate_size(void)
{
/* Recompute the context size for enabled features: */
- unsigned int user_size, kernel_size, kernel_default_size;
+ unsigned int user_size, kernel_size;
bool compacted = cpu_feature_enabled(X86_FEATURE_XCOMPACTED);
/* Uncompacted user space size */
@@ -692,18 +692,20 @@ static int __init init_xstate_size(void)
else
kernel_size = user_size;
- kernel_default_size =
- xstate_calculate_size(fpu_kernel_cfg.default_features, compacted);
-
if (!paranoid_xstate_size_valid(kernel_size))
return -EINVAL;
fpu_kernel_cfg.max_size = kernel_size;
fpu_user_cfg.max_size = user_size;
- fpu_kernel_cfg.default_size = kernel_default_size;
+ fpu_kernel_cfg.default_size =
+ xstate_calculate_size(fpu_kernel_cfg.default_features, compacted);
+ fpu_kernel_cfg.guest_default_size =
+ xstate_calculate_size(fpu_kernel_cfg.guest_default_features, compacted);
fpu_user_cfg.default_size =
xstate_calculate_size(fpu_user_cfg.default_features, false);
+ fpu_user_cfg.guest_default_size =
+ xstate_calculate_size(fpu_user_cfg.guest_default_features, false);
return 0;
}
@@ -721,8 +723,10 @@ static void __init fpu__init_disable_system_xstate(unsigned int legacy_size)
/* Restore the legacy size.*/
fpu_kernel_cfg.max_size = legacy_size;
fpu_kernel_cfg.default_size = legacy_size;
+ fpu_kernel_cfg.guest_default_size = legacy_size;
fpu_user_cfg.max_size = legacy_size;
fpu_user_cfg.default_size = legacy_size;
+ fpu_user_cfg.guest_default_size = legacy_size;
/*
* Prevent enabling the static branch which enables writes to the
@@ -807,9 +811,11 @@ void __init fpu__init_system_xstate(unsigned int legacy_size)
/* Clean out dynamic features from default */
fpu_kernel_cfg.default_features = fpu_kernel_cfg.max_features;
fpu_kernel_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;
+ fpu_kernel_cfg.guest_default_features = fpu_kernel_cfg.default_features;
fpu_user_cfg.default_features = fpu_user_cfg.max_features;
fpu_user_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;
+ fpu_user_cfg.guest_default_features = fpu_user_cfg.default_features;
/* Store it for paranoia check at the end */
xfeatures = fpu_kernel_cfg.max_features;
--
2.46.1
Powered by blists - more mailing lists