linux-kernel - Re: [PATCH v2 1/4] KVM: TDX: Fix definition of tdx_guest_nr_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a9335bdf4fbfef9d34c448d1bd8f075e56f82bc.camel@intel.com>
Date: Tue, 18 Mar 2025 15:33:27 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "pbonzini@...hat.com" <pbonzini@...hat.com>, "Verma, Vishal L"
	<vishal.l.verma@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"binbin.wu@...xu.intel.com" <binbin.wu@...xu.intel.com>
Subject: Re: [PATCH v2 1/4] KVM: TDX: Fix definition of
 tdx_guest_nr_guest_keyids()

On Tue, 2025-03-18 at 00:35 -0600, Vishal Verma wrote:
> When CONFIG_INTEL_TDX_HOST=n, the above definition produced an
> unused-function warning with gcc.
> 
>   error: ‘tdx_get_nr_guest_keyids’ defined but not used [-Werror=unused-function]
>     198 | static u32 tdx_get_nr_guest_keyids(void) { return 0; }
>         |            ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Make the definition 'inline' so that in the config disabled case, the
> whole thing can be optimized away.

This looks to be fixed in the current kvm-coco-queue. Can you double check?

> 
> Cc: Sean Christopherson <seanjc@...gle.com>
> Cc: Rick Edgecombe <rick.p.edgecombe@...el.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@...el.com>
> ---
>  arch/x86/include/asm/tdx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
> index e6b003fe7f5e..fbc22bf39cfd 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -195,7 +195,7 @@ u64 tdh_phymem_page_wbinvd_hkid(u64 hkid, struct page *page);
>  static inline void tdx_init(void) { }
>  static inline int tdx_cpu_enable(void) { return -ENODEV; }
>  static inline int tdx_enable(void)  { return -ENODEV; }
> -static u32 tdx_get_nr_guest_keyids(void) { return 0; }
> +static inline u32 tdx_get_nr_guest_keyids(void) { return 0; }
>  static inline const char *tdx_dump_mce_info(struct mce *m) { return NULL; }
>  static inline const struct tdx_sys_info *tdx_get_sysinfo(void) { return NULL; }
>  #endif	/* CONFIG_INTEL_TDX_HOST */
>