linux-kernel - Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde38364-5c20-4030-ad7d-9ae38971b260@kernel.org>
Date: Tue, 18 Mar 2025 17:23:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sergio Pérez <sergio@...eznus.es>,
 linux-iio@...r.kernel.org
Cc: tduszyns@...il.com, jic23@...nel.org, lars@...afoo.de, robh@...nel.org,
 conor+dt@...nel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

On 18/03/2025 17:21, Krzysztof Kozlowski wrote:
> On 18/03/2025 17:06, Sergio Pérez wrote:
>>
>> El 18/03/2025 a las 16:16, Krzysztof Kozlowski escribió:
>>> On 18/03/2025 15:16, Sergio Pérez wrote:
>>>> Hello,
>>>>
>>>> El 17/03/2025 a las 8:24, Krzysztof Kozlowski escribió:
>>>>> On 16/03/2025 15:55, Sergio Perez wrote:
>>>>>> Some BH1750 sensors require a hardware reset before they can be
>>>>>> detected on the I2C bus. This patch adds support for an optional
>>>>>> reset GPIO that can be specified in the device tree.
>>>>>>
>>>>>> The reset sequence pulls the GPIO low and then high before
>>>>>> initializing the sensor, which enables proper detection with
>>>>>> tools like i2cdetect.
>>>>>>
>>>>>> Update the devicetree binding documentation to include the new
>>>>>> reset-gpios property with examples.
>>>>>>
>>>>>> Signed-off-by: Sergio Perez <sergio@...eznus.es>
>>>>> Please run scripts/checkpatch.pl and fix reported warnings. After that,
>>>>> run also `scripts/checkpatch.pl --strict` and (probably) fix more
>>>>> warnings. Some warnings can be ignored, especially from --strict run,
>>>>> but the code here looks like it needs a fix. Feel free to get in touch
>>>>> if the warning is not clear.
>>> You keep ignoring paragraphs. Did you read this?
>>
>> I pass this check several times and every time I do any step to make 
>> sure I am well.
>>
>> scripts/checkpatch.pl -f drivers/iio/light/bh1750.c
>> total: 0 errors, 0 warnings, 354 lines checked
> 
> 
> That's not how you run checkpatch. Read the submitting patches. Just
> like the name tells you, check the patch, you run it on the patch.
BTW, I wonder which guideline told you to run it on the file? Because
checkpatch description and submitting patches tell about running it on
the patches, so I wonder where did you get suggestion to run it like that?

Best regards,
Krzysztof