linux-kernel - Re: [PATCH] perf kwork: Remove unreachable judgments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250318021703.78297-1-yangfeng59949@163.com>
Date: Tue, 18 Mar 2025 10:17:03 +0800
From: Feng Yang <yangfeng59949@....com>
To: irogers@...gle.com
Cc: acme@...nel.org,
	adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org,
	kan.liang@...ux.intel.com,
	linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	mark.rutland@....com,
	mingo@...hat.com,
	namhyung@...nel.org,
	peterz@...radead.org,
	yangfeng59949@....com
Subject: Re: [PATCH] perf kwork: Remove unreachable judgments

On Mon, 17 Mar 2025 08:44:45 -0700 Ian Rogers <irogers@...gle.com> wrote:
> 
> On Thu, Mar 13, 2025 at 8:10 PM Feng Yang <yangfeng59949@....com> wrote:
> >
> > From: Feng Yang <yangfeng@...inos.cn>
> >
> > When s2[i] = '\0', if s1[i] != '\0', it will be judged by ret,
> > and if s1[i] = '\0', it will be judegd by !s1[i].
> > So in reality, s2 [i] will never make a judgment
> 
> Sgtm. Out of curiosity, was this tripping a compiler warning? If so,
> could you provide the details?
> 
> Thanks,
> Ian

There was no warning during compilation,
I just accidentally discovered it while testing and analyzing this code.

Feng