[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cfdbfe7e-5cf4-47a7-af5f-b220cad6f7e4@amd.com>
Date: Tue, 18 Mar 2025 22:14:29 +0530
From: Rajaganesh Rathinasabapathi <rrathina@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@....com>
Cc: devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org, joel@....id.au,
andrew@...econstruct.com.au, robh+dt@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
Supreeth Venkatesh <supreeth.venkatesh@....com>
Subject: Re: [PATCH v3 2/2] ARM:dts:aspeed: Initial device tree for AMD Onyx
Platform
On 3/18/25 14:15, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Mon, Mar 17, 2025 at 11:12:24PM -0500, Rajaganesh Rathinasabapathi wrote:
>> +/ {
>> + model = "AMD Onyx BMC";
>> + compatible = "amd,onyx-bmc", "aspeed,ast2600";
>> +
>> + aliases {
>> + serial0 = &uart1;
>> + serial4 = &uart5;
>> + };
>> +
>> + chosen {
>> + stdout-path = serial4:115200n8;
>> + };
>> +
>> + memory@...00000 {
>> + device_type = "memory";
>> + reg = <0x80000000 0x80000000>;
>> + };
>> +
>> +};
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
> Best regards,
> Krzysztof
>
There were two comments. One was to remove bootargs, this is addressed in v3.
Another comment was to add compatibles for amd,onyx-bmc, it part of earlier commit (patch v3 1/2).
Thanks,
Raja
Powered by blists - more mailing lists