linux-kernel - Re: [PATCH] drm/panel/sharp-ls043t1le01: Use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAO9ioeXyJKGxXXanFHraspvquwWmMEKUdw_eN=wjV81VeMo43w@mail.gmail.com>
Date: Tue, 18 Mar 2025 19:00:02 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Anusha Srivatsa <asrivats@...hat.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Tejas Vipin <tejasvipin76@...il.com>,
        Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH] drm/panel/sharp-ls043t1le01: Use _multi variants

On Tue, 18 Mar 2025 at 18:55, Anusha Srivatsa <asrivats@...hat.com> wrote:
>
> On Sun, Mar 16, 2025 at 7:32 PM Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
>>
>> On Sun, Mar 16, 2025 at 02:58:22PM -0400, Anusha Srivatsa wrote:

>> > ---
>> >  drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 36 ++++++++++---------------
>> >  1 file changed, 14 insertions(+), 22 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
>> > index 729cbb0d8403ff7c0c4b9d21774909cc298904a2..9803eaf18e95d70742ece88e82932751476fdda8 100644
>> > --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
>> > +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
>> > @@ -36,15 +36,14 @@ static inline struct sharp_nt_panel *to_sharp_nt_panel(struct drm_panel *panel)
>> >  static int sharp_nt_panel_init(struct sharp_nt_panel *sharp_nt)
>> >  {
>> >       struct mipi_dsi_device *dsi = sharp_nt->dsi;
>> > +     struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>> >       int ret;
>> >
>> >       dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>> >
>> > -     ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
>> > -     if (ret < 0)
>> > -             return ret;
>> > +     mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
>> >
>> > -     msleep(120);
>> > +     mipi_dsi_msleep(&dsi_ctx, 120);
>> >
>> >       /* Novatek two-lane operation */
>> >       ret = mipi_dsi_dcs_write(dsi, 0xae, (u8[]){ 0x03 }, 1);
>>
>> Anusha. Please. Start reviewing your patches before you send them. This
>> is a MIPI DSI call. And it wasn't switched to _multi / context. You
>> should have cought this. I don't know why you didn't. Please review and
>> check your code before sending it upstream.
>
>
> Actually , mipi_dsi_dcs_write() doesnt have a _multi() variant. There are _multi() variants for other writes: mipi_dsi_dcs_write_buffer() has mipi_dsi_dcs_write_buffer_multi(), mipi_dsi_generic_write() has mipi_dsi_generic_write_multi() but not the one used above.

That doesn't mean that it can be left unconverted. You can use
mipi_dsi_dcs_write_buffer_multi().

P.S. Please wrap your replies ont some useful boundary (72-75 chars is
the recommended value).

-- 
With best wishes
Dmitry