[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250318211959.8557-1-arapovl839@gmail.com>
Date: Tue, 18 Mar 2025 21:19:51 +0000
From: Leonid Arapov <arapovl839@...il.com>
To: Helge Deller <deller@....de>
Cc: Leonid Arapov <arapovl839@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"Dr. David Alan Gilbert" <linux@...blig.org>,
Uwe Kleine-König <u.kleine-koenig@...libre.com>,
linux-omap@...r.kernel.org,
linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: [PATCH 1/2] fbdev: omapfb: Remove writeback deadcode
Value of enum parameter 'plane' is initialized in dss_init_overlays and
cannot take the value OMAP_DSS_WB. Function dispc_ovl_setup_common could
be called with this value of parameter only from dispc_wb_setup, which has
never been used and has been removed in commit 4f55bb03801a
("omapfb: Remove unused writeback code"). The code in the if-branch is
unreachable.
Remove unreachable branch.
Found by Linux Verification Center (linuxtesting.org) with SVACE static
analysis tool.
Signed-off-by: Leonid Arapov <arapovl839@...il.com>
---
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
index ccb96a5be07e..8db074862824 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
@@ -2659,13 +2659,8 @@ static int dispc_ovl_setup_common(enum omap_plane plane,
row_inc = 0;
pix_inc = 0;
- if (plane == OMAP_DSS_WB) {
- frame_width = out_width;
- frame_height = out_height;
- } else {
- frame_width = in_width;
- frame_height = height;
- }
+ frame_width = in_width;
+ frame_height = height;
if (rotation_type == OMAP_DSS_ROT_TILER)
calc_tiler_rotation_offset(screen_width, frame_width,
--
2.45.2
Powered by blists - more mailing lists