linux-kernel - Re: [PATCH 2/2] rust: alloc: add `Vec::dec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mHvjPn98mcXh3q18nB5pPH6YBj3jf1YH6510bP-mtFtQ@mail.gmail.com>
Date: Tue, 18 Mar 2025 14:28:02 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Benno Lossin <benno.lossin@...ton.me>, Danilo Krummrich <dakr@...nel.org>, 
	Andrew Ballance <andrewjballance@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rust: alloc: add `Vec::dec_len`

On Tue, Mar 18, 2025 at 10:44 AM Alice Ryhl <aliceryhl@...gle.com> wrote:
>
> On Tue, Mar 18, 2025 at 10:12:28AM -0400, Tamir Duberstein wrote:\
> >
> > The methods you're describing are all on Vec, right? In other words,
> > their usage calls for a private `dec_len` or `set_len`. As I've said
> > repeatedly in the course of this discussion: I would prefer not to
> > introduce `dec_len` at all here. It (or `set_len`) can be introduced
> > in the series that adds truncate or your patch that adds clear, where
> > its signature can be properly scrutinized in the context of an actual
> > caller.
>
> Oh I did not see that you said that. Dropping patch 2 is fine with me.
>
> Alice

Benno, Danilo: are you both OK with this? I'll discard this patch on
the respin and prepend the patch adding the len <= cap invariant.