linux-kernel - Re: [PATCH v2 3/4] rust: auxiliary: add auxiliary registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D8JLYJIT03KN.25S8FOEO26DOH@proton.me>
Date: Tue, 18 Mar 2025 18:36:52 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Benoît du Garreau <benoit@...arreau.fr>, Danilo Krummrich <dakr@...nel.org>
Cc: gregkh@...uxfoundation.org, rafael@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu, airlied@...il.com, acourbot@...dia.com, jhubbard@...dia.com, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2 3/4] rust: auxiliary: add auxiliary registration

On Mon Mar 17, 2025 at 9:42 PM CET, Benoît du Garreau wrote:
> On Thu, 13 Mar 2025 03:23:52 +0100 Danilo Krummrich <dakr@...nel.org> wrote:
>> Implement the `auxiliary::Registration` type, which provides an API to
>> +impl Registration {
>> +    /// Create and register a new auxiliary device.
>> +    pub fn new(parent: &device::Device, name: &CStr, id: u32, modname: &CStr) -> Result<Self> {
>> +        let boxed = KBox::new(Opaque::<bindings::auxiliary_device>::zeroed(), GFP_KERNEL)?;
>
> You can use `KBox::init(kernel::init::zeroed(), GFP_KERNEL)` here. It avoids
> the need for the first patch.

We probably should have the zeroed function on the `Zeroable` trait...

---
Cheers,
Benno