linux-kernel - Re: [PATCH v2 1/1] scsi: ufs: core: add device level exception support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98b420e3-87ee-4034-8cb4-76b8e30d7920@acm.org>
Date: Tue, 18 Mar 2025 14:21:10 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>, quic_cang@...cinc.com,
 quic_nitirawa@...cinc.com, avri.altman@....com, peter.wang@...iatek.com,
 manivannan.sadhasivam@...aro.org, minwoo.im@...sung.com,
 adrian.hunter@...el.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 Bean Huo <beanhuo@...ron.com>, Ziqi Chen <quic_ziqichen@...cinc.com>,
 Keoseong Park <keosung.park@...sung.com>,
 Gwendal Grignou <gwendal@...omium.org>, Al Viro <viro@...iv.linux.org.uk>,
 Eric Biggers <ebiggers@...gle.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] scsi: ufs: core: add device level exception
 support

On 3/14/25 3:55 PM, Bao D. Nguyen wrote:
> +	if (status & hba->ee_drv_mask & MASK_EE_DEV_LVL_EXCEPTION) {
> +		hba->dev_lvl_exception_count++;
> +		sysfs_notify(&hba->dev->kobj, NULL, "device_lvl_exception_count");
> +	}
This increment can race with the code in 
device_lvl_exception_count_store() for clearing
hba->dev_lvl_exception_count. Shouldn't the clearing code and the
code for incrementing hba->dev_lvl_exception_count be serialized in
some way?

Thanks,

Bart.