linux-kernel - Re: [PATCH 4/8] arm64: dts: qcom: msm8998: Remove mdss_hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pxnpqoolslizrgvjvr3mblxz5hhedwx22xkhrwck56g7cdlmjt@3r7l5cmmqn65>
Date: Tue, 18 Mar 2025 23:32:21 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Konrad Dybcio <konradybcio@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        Marc Gonzalez <mgonzalez@...ebox.fr>,
        Dmitry Baryshkov <lumag@...nel.org>, Arnaud Vrac <avrac@...ebox.fr>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH 4/8] arm64: dts: qcom: msm8998: Remove mdss_hdmi_phy
 phandle argument

On Tue, Mar 18, 2025 at 07:35:17PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> The node has #clock-cells = <0>, as it only provides a single clock
> output.
> 
> This leads to a turbo sneaky bug, where the dt checker shows that we
> have additional clocks in the array:
> 
> clock-controller@...0000: clocks: [[3, 0], [39, 178], [156, 1],
> [156, 0], [157, 1], [157, 0], [158], [0], [0], [0], [39, 184]]
> is too long
> 
> ..which happens due to dtc interpreting <&mdss_hdmi_phy 0> as
> <&mdss_hdmi_phy>, <0> after taking cells into account.
> 
> Remove the superfluous argument to both silence the warning and fix
> the index-based lookup of subsequent entries in "clocks".
> 
> Fixes: 2150c87db80c ("arm64: dts: qcom: msm8998: add HDMI nodes")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>

-- 
With best wishes
Dmitry