linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4srz3ztdena2p2vlzymfmk6oz7q6ocww7y7mdxiyfgdrpu5may@nhlvmj2ofkcs>
Date: Tue, 18 Mar 2025 23:39:27 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Stone Zhang <quic_stonez@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_miaoqing@...cinc.com, quic_zhichen@...cinc.com,
        quic_yuzha@...cinc.com
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on
 qcs8300-ride

On Tue, Mar 18, 2025 at 04:54:25PM +0100, Konrad Dybcio wrote:
> On 3/18/25 10:33 AM, Stone Zhang wrote:
> > Enable WLAN on qcs8300-ride by adding a node for the PMU module
> > of the WCN6855 and assigning its LDO power outputs to the existing
> > WiFi module.
> > 
> > Signed-off-by: Stone Zhang <quic_stonez@...cinc.com>
> > ---
> 
> This change looks good generally, but please align the various stylistic
> things, like property order in the nodes you add with x1e80100-crd.dtsi
> 
> I also see that board-2.bin doesn't contain the variant string you've
> suggested ([1] @ commit 646e008ec53a8bb9ae16ebf98a65b29eaefd6da4)

Yes. Please at least send it to the ath11k list as documented at [2]

> 
> Konrad
> 
> [1] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware/-/blob/main/WCN6855/hw2.0/board-2.bin?ref_type=heads

[2] https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html

-- 
With best wishes
Dmitry