linux-kernel - Re: [PATCH v4 08/13] serial: sh-sci: Introduced function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9npYaRwzhsoLxS9@shikoro>
Date: Tue, 18 Mar 2025 22:45:05 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Paul Barker <paul.barker.ct@...renesas.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Thierry Bultel <thierry.bultel.yh@...renesas.com>,
	thierry.bultel@...atsea.fr, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Ulrich Hecht <uli@...nd.eu>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH v4 08/13] serial: sh-sci: Introduced function pointers

Hi Paul,

> We discussed both approaches internally and did an initial
> proof-of-concept of a separate driver. The result was over 1,000 lines
> of code copy-pasted from the existing sh-sci driver into the new driver,
> which is generally something maintainers want us to avoid doing.

Darn, 1000 lines of logic is a lot...

> trade off here is whether we want a single more complex driver, or two
> copies of much of the code so that bugfixes/improvements to the common
> sections in the future need to be duplicated.

Exactly.

> The RZ/V2H and RZ/G3E have interfaces of both the existing sh-sci
> register layout ("SCIF" ports in RZ/V2H & RZ/G3E manual) and the RZ/T2H
> style register layout ("RSCI" ports in RZ/V2H manual, "SCI" ports in
> RZ/G3E manual), so keeping things closely aligned as we move forward
> will be beneficial. I expect that this will be easier with a combined
> driver.

I will have a look at the series.

Happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)