[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ebd72f1c-00fd-4cbd-8dd1-db723bf2ac0d@amd.com>
Date: Mon, 17 Mar 2025 22:30:31 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Luke Jones <luke@...nes.dev>, linux-kernel@...r.kernel.org
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com,
platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v7 6/8] platform/x86: asus-armoury: add screen
auto-brightness toggle
On 3/16/2025 18:07, Luke Jones wrote:
> Add screen_auto_brightness toggle supported on some laptops.
>
> Signed-off-by: Luke D. Jones <luke@...nes.dev>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
> drivers/platform/x86/asus-armoury.c | 3 +++
> include/linux/platform_data/x86/asus-wmi.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 6f0686fd5a4b..591805f46725 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -752,6 +752,9 @@ ATTR_GROUP_BOOL_RW(panel_od, "panel_overdrive", ASUS_WMI_DEVID_PANEL_OD,
> "Set the panel refresh overdrive");
> ATTR_GROUP_BOOL_RW(panel_hd_mode, "panel_hd_mode", ASUS_WMI_DEVID_PANEL_HD,
> "Set the panel HD mode to UHD<0> or FHD<1>");
> +ATTR_GROUP_BOOL_RW(screen_auto_brightness, "screen_auto_brightness",
> + ASUS_WMI_DEVID_SCREEN_AUTO_BRIGHTNESS,
> + "Set the panel brightness to Off<0> or On<1>");
> ATTR_GROUP_BOOL_RO(egpu_connected, "egpu_connected", ASUS_WMI_DEVID_EGPU_CONNECTED,
> "Show the eGPU connection status");
>
> diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
> index e735f35b423c..92fea0710ada 100644
> --- a/include/linux/platform_data/x86/asus-wmi.h
> +++ b/include/linux/platform_data/x86/asus-wmi.h
> @@ -83,6 +83,7 @@
> #define ASUS_WMI_DEVID_LID_FLIP_ROG 0x00060077
> #define ASUS_WMI_DEVID_MINI_LED_MODE 0x0005001E
> #define ASUS_WMI_DEVID_MINI_LED_MODE2 0x0005002E
> +#define ASUS_WMI_DEVID_SCREEN_AUTO_BRIGHTNESS 0x0005002A
>
> /* Storage */
> #define ASUS_WMI_DEVID_CARDREADER 0x00080013
Powered by blists - more mailing lists