linux-kernel - Re: [PATCH 6.6.y] netfilter: nf_tables: use timestamp to check for set element timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9nxUdl9OcOlEl8L@calendula>
Date: Tue, 18 Mar 2025 23:18:57 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: gregkh@...uxfoundation.org, sashal@...nel.org
Cc: jianqi.ren.cn@...driver.com, stable@...r.kernel.org,
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
	kadlec@...filter.org, fw@...len.de, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	kaber@...sh.net, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org
Subject: Re: [PATCH 6.6.y] netfilter: nf_tables: use timestamp to check for
 set element timeout

Hi Greg, Sasha,

This backport is correct, please apply to -stable 6.6

On Mon, Mar 17, 2025 at 04:16:32PM +0800, jianqi.ren.cn@...driver.com wrote:
> From: Pablo Neira Ayuso <pablo@...filter.org>
> 
> [ Upstream commit 7395dfacfff65e9938ac0889dafa1ab01e987d15 ]
> 
> Add a timestamp field at the beginning of the transaction, store it
> in the nftables per-netns area.
> 
> Update set backend .insert, .deactivate and sync gc path to use the
> timestamp, this avoids that an element expires while control plane
> transaction is still unfinished.
> 
> .lookup and .update, which are used from packet path, still use the
> current time to check if the element has expired. And .get path and dump
> also since this runs lockless under rcu read size lock. Then, there is
> async gc which also needs to check the current time since it runs
> asynchronously from a workqueue.
> 
> Fixes: c3e1b005ed1c ("netfilter: nf_tables: add set element timeout support")
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> Signed-off-by: Jianqi Ren <jianqi.ren.cn@...driver.com>
> Signed-off-by: He Zhe <zhe.he@...driver.com>

Reviewed-by: Pablo Neira Ayuso <pablo@...filter.org>
Tested-by: Pablo Neira Ayuso <pablo@...filter.org>