linux-kernel - Re: [tip: objtool/core] objtool: Add CONFIG_OBJTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <zy43nfn4ttzw2j632vn4emgmgrgg5kei4gu2xp2dn2zn6ohzed@exwbw6yvxarp>
Date: Mon, 17 Mar 2025 21:59:01 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: tip-bot2 for Josh Poimboeuf <tip-bot2@...utronix.de>, 
	Ingo Molnar <mingo@...nel.org>
Cc: linux-tip-commits@...r.kernel.org, 
	"Peter Zijlstra (Intel)" <peterz@...radead.org>, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [tip: objtool/core] objtool: Add CONFIG_OBJTOOL_WERROR

On Mon, Mar 17, 2025 at 05:27:32PM -0700, Josh Poimboeuf wrote:
> On Mon, Mar 17, 2025 at 11:07:23AM +0000, tip-bot2 for Josh Poimboeuf wrote:
> > The following commit has been merged into the objtool/core branch of tip:
> > 
> > Commit-ID:     36799069b48198e5ce92d99310060c4aecb4b3e3
> > Gitweb:        https://git.kernel.org/tip/36799069b48198e5ce92d99310060c4aecb4b3e3
> > Author:        Josh Poimboeuf <jpoimboe@...nel.org>
> > AuthorDate:    Fri, 14 Mar 2025 12:29:11 -07:00
> > Committer:     Peter Zijlstra <peterz@...radead.org>
> > CommitterDate: Mon, 17 Mar 2025 11:51:44 +01:00
> > 
> > objtool: Add CONFIG_OBJTOOL_WERROR
> > 
> > Objtool warnings can be indicative of crashes, broken live patching, or
> > even boot failures.  Ignoring them is not recommended.
> > 
> > Add CONFIG_OBJTOOL_WERROR to upgrade objtool warnings to errors by
> > enabling the objtool --Werror option.  Also set --backtrace to print the
> > branches leading up to the warning, which can help considerably when
> > debugging certain warnings.
> > 
> > To avoid breaking bots too badly for now, make it the default for real
> > world builds only (!COMPILE_TEST).
> 
> This last paragraph is no longer accurate, looks like it was changed to
> be off by default.

Also, given all the review comments, should I post a v2 set to replace
the merged commits?

-- 
Josh