linux-kernel - Re: [PATCH v6 13/13] xfs: update atomic write max size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250318054718.GA14895@lst.de>
Date: Tue, 18 Mar 2025 06:47:18 +0100
From: Christoph Hellwig <hch@....de>
To: John Garry <john.g.garry@...cle.com>
Cc: brauner@...nel.org, djwong@...nel.org, cem@...nel.org,
	dchinner@...hat.com, linux-xfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	ojaswin@...ux.ibm.com, ritesh.list@...il.com,
	martin.petersen@...cle.com, tytso@....edu,
	linux-ext4@...r.kernel.org, Carlos Maiolino <cmaiolino@...hat.com>
Subject: Re: [PATCH v6 13/13] xfs: update atomic write max size

On Mon, Mar 17, 2025 at 09:57:45AM +0000, John Garry wrote:
>> And handle the case where there
>> is no hardware support at all.
>
> So xfs_get_atomic_write_max_attr() -> xfs_inode_can_atomicwrite() covers no 
> HW support.
>
> The point of this function is just to calc atomic write limits according to 
> mount point geometry and features.
>
> Do you think that it is necessary to call xfs_inode_can_atomicwrite() here 
> also? [And remove the xfs_get_atomic_write_max_attr() -> 
> xfs_inode_can_atomicwrite()?]

At least document what it does..

>>> +static inline void
>>> +xfs_compute_awu_max(
>>
>> And use a more descriptive name than AWU, wich really just is a
>> nvme field name.
>
> I am just trying to be concise to limit spilling lines.
>
> Maybe atomicwrite_unit_max is preferred

I guess if we ant to stick to the unit encoded in awu and used by the
block layer, yes.