linux-kernel - RE: [PATCH] iio: hid-sensor-prox: Add support for 16-bit report size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB5995BA99252884FFFDD7234393DE2@DM4PR11MB5995.namprd11.prod.outlook.com>
Date: Tue, 18 Mar 2025 00:56:43 +0000
From: "Zhang, Lixu" <lixu.zhang@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
CC: "jikos@...nel.org" <jikos@...nel.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"lars@...afoo.de" <lars@...afoo.de>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: hid-sensor-prox: Add support for 16-bit report size

>-----Original Message-----
>From: Jonathan Cameron <jic23@...nel.org>
>Sent: Monday, March 17, 2025 8:21 PM
>To: Zhang, Lixu <lixu.zhang@...el.com>
>Cc: jikos@...nel.org; srinivas.pandruvada@...ux.intel.com; lars@...afoo.de;
>linux-input@...r.kernel.org; linux-iio@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: Re: [PATCH] iio: hid-sensor-prox: Add support for 16-bit report size
>
>On Mon, 17 Mar 2025 09:36:34 +0800
>Zhang Lixu <lixu.zhang@...el.com> wrote:
>
>> On Intel platforms, the HID_USAGE_SENSOR_HUMAN_PROXIMITY report size
>> is 16 bits. This patch adds support for handling 16-bit report sizes
>> for the HID_USAGE_SENSOR_HUMAN_PROXIMITY usage in the HID sensor
>proximity driver.
>>
>> Previously, the driver only supported 8-bit and 32-bit report sizes.
>> With this change, the driver can now correctly process 16-bit
>> proximity data, ensuring accurate human presence detection on
>> platforms where this report size is used.
>>
>> Signed-off-by: Zhang Lixu <lixu.zhang@...el.com>
>> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
>Applied. Thanks.
>
>If it is reasonably urgent we could slip this in after rc1 as it smells a bit fix like.
>For now I've queued it for next cycle.

I don't think it's urgent, I'm fine with whatever. Thanks.

Lixu

>Jonathan
>
>> ---
>>  drivers/iio/light/hid-sensor-prox.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/iio/light/hid-sensor-prox.c
>> b/drivers/iio/light/hid-sensor-prox.c
>> index 76b76d12b388..3a7b48803d50 100644
>> --- a/drivers/iio/light/hid-sensor-prox.c
>> +++ b/drivers/iio/light/hid-sensor-prox.c
>> @@ -213,6 +213,9 @@ static int prox_capture_sample(struct
>hid_sensor_hub_device *hsdev,
>>  	case 1:
>>  		prox_state->human_presence[chan] = *(u8 *)raw_data *
>multiplier;
>>  		return 0;
>> +	case 2:
>> +		prox_state->human_presence[chan] = *(u16 *)raw_data *
>multiplier;
>> +		return 0;
>>  	case 4:
>>  		prox_state->human_presence[chan] = *(u32 *)raw_data *
>multiplier;
>>  		return 0;
>>
>> base-commit: eea255893718268e1ab852fb52f70c613d109b99