linux-kernel - Re: [PATCH 03/18] rtc: aspeed: drop needless struct aspeed_rtc::rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e6a356cf1e6f293a2218e1c006f0222c9e01fa6.camel@codeconstruct.com.au>
Date: Tue, 18 Mar 2025 11:28:28 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: André Draszik <andre.draszik@...aro.org>, Chanwoo
 Choi <cw00.choi@...sung.com>, Krzysztof Kozlowski <krzk@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>, Joel Stanley
 <joel@....id.au>, Hans Ulli Kroll <ulli.kroll@...glemail.com>, Linus
 Walleij <linus.walleij@...aro.org>, Neil Armstrong
 <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, Jerome
 Brunet <jbrunet@...libre.com>, Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>,  Tóth János
 <gomba007@...il.com>, Dianlong Li <long17.cool@....com>
Cc: linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org, 
	linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 03/18] rtc: aspeed: drop needless struct
 aspeed_rtc::rtc_dev member

On Fri, 2025-02-28 at 14:07 +0000, André Draszik wrote:
> The memory pointed to by the ::rtc_dev member is managed via devres,
> and no code in this driver uses it past _probe().
> 
> We can drop it from the structure and just use a local temporary
> variable, reducing runtime memory consumption by a few bytes.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>

Reviewed-by: Andrew Jeffery <andrew@...econstruct.com.au>