linux-kernel - Re: [PATCH v2 2/2] iio: adc: adding support for PAC194X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202503181451.vybqC7U2-lkp@intel.com>
Date: Tue, 18 Mar 2025 15:05:53 +0800
From: kernel test robot <lkp@...el.com>
To: marius.cristea@...rochip.com, jic23@...nel.org, lars@...afoo.de,
	robh@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, krzk+dt@...nel.org, conor+dt@...nel.org,
	oskar.andero@...il.com, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	marius.cristea@...rochip.com
Subject: Re: [PATCH v2 2/2] iio: adc: adding support for PAC194X

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 577a66e2e634f712384c57a98f504c44ea4b47da]

url:    https://github.com/intel-lab-lkp/linux/commits/marius-cristea-microchip-com/dt-bindings-iio-adc-adding-support-for-PAC194X/20250317-171150
base:   577a66e2e634f712384c57a98f504c44ea4b47da
patch link:    https://lore.kernel.org/r/20250317090803.30003-3-marius.cristea%40microchip.com
patch subject: [PATCH v2 2/2] iio: adc: adding support for PAC194X
config: sparc-randconfig-r073-20250318 (https://download.01.org/0day-ci/archive/20250318/202503181451.vybqC7U2-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250318/202503181451.vybqC7U2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503181451.vybqC7U2-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/pac1944.c:614: warning: Function parameter or struct member 'active_channels_mask' not described in 'pac1944_chip_info'


vim +614 drivers/iio/adc/pac1944.c

   546	
   547	/**
   548	 * struct pac1944_chip_info - chip configuration
   549	 * @channels: array of values, true means that channel is active
   550	 * @iio_info: pointer to iio_info structure
   551	 * @client: a pointer to the i2c client associated with the device
   552	 * @lock: lock to prevent concurrent reads/writes
   553	 * @work_chip_rfsh: chip refresh workqueue implementation
   554	 * @phys_channels: number of physical channels for the device
   555	 * @active_channels: array of values, true means that channel is active
   556	 * @chip_variant: stores the type of the device
   557	 * @chip_revision: store the silicon revision version of the device
   558	 * @shunts: array of values, shunt resistor values
   559	 * @chip_reg_data: pointer to structure, containing data from the device registers
   560	 * @sample_rate_value: sampling frequency
   561	 * @labels: array of string, name of each channel
   562	 * @is_pac195x_family: true if device is part of the PAC195x family
   563	 * @sampling_mode: sampling mode used by the device
   564	 * @num_enabled_channels: count of how many chip channels are currently enabled
   565	 * @slow_alert1: snapshot of slow/alert register
   566	 * @gpio_alert2: snapshot of gpio/alert register
   567	 * @acc_fullness: snapshot of accumulator fullness limit register
   568	 * @overcurrent: array of values, overcurrent limit
   569	 * @undercurrent: array of values, undercurrent limit
   570	 * @overpower: array of values, overpower limit
   571	 * @overvoltage:  array of values, overvoltage limit
   572	 * @undervoltage: array of values, undervoltage limit
   573	 * @oc_limit_nsamples: number of consecutive samples exceeding the overcurrent limit
   574	 * @uc_limit_nsamples: number of consecutive samples exceeding the undercurrent limit
   575	 * @op_limit_nsamples: number of consecutive samples exceeding the overpower limit
   576	 * @ov_limit_nsamples: number of consecutive samples exceeding the overvoltage limit
   577	 * @uv_limit_nsamples: number of consecutive samples exceeding the undervoltage limit
   578	 * @alert_enable: snapshot of alert enable register
   579	 * @enable_acc: array of values, true means that accumulation channel is measured
   580	 */
   581	struct pac1944_chip_info {
   582		const struct iio_chan_spec  *channels;
   583		struct iio_info		iio_info;
   584		struct i2c_client	*client;
   585		struct mutex		lock; /* lock to prevent concurrent reads/writes */
   586		struct delayed_work	work_chip_rfsh;
   587		u8		phys_channels;
   588		bool		active_channels[PAC1944_MAX_CH];
   589		unsigned long	active_channels_mask;
   590		u8		chip_variant;
   591		u8		chip_revision;
   592		u32		shunts[PAC1944_MAX_CH];
   593		struct reg_data chip_reg_data;
   594		s32		sample_rate_value;
   595		char		*labels[PAC1944_MAX_CH];
   596		bool		is_pac195x_family;
   597		u8		sampling_mode;
   598		u8		num_enabled_channels;
   599		u32		slow_alert1;
   600		u32		gpio_alert2;
   601		u16		acc_fullness;
   602		u16		overcurrent[PAC1944_MAX_CH];
   603		u16		undercurrent[PAC1944_MAX_CH];
   604		u32		overpower[PAC1944_MAX_CH];
   605		u16		overvoltage[PAC1944_MAX_CH];
   606		u16		undervoltage[PAC1944_MAX_CH];
   607		u8		oc_limit_nsamples[PAC1944_MAX_CH];
   608		u8		uc_limit_nsamples[PAC1944_MAX_CH];
   609		u8		op_limit_nsamples[PAC1944_MAX_CH];
   610		u8		ov_limit_nsamples[PAC1944_MAX_CH];
   611		u8		uv_limit_nsamples[PAC1944_MAX_CH];
   612		u32		alert_enable;
   613		bool		enable_acc[PAC1944_MAX_CH];
 > 614	};
   615	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki