linux-kernel - Re: [PATCH] mtd: spi-nor: gigadevice: add lock flags for GD25Q128/256 and GD25LQ128D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4be8afd5-65a9-4cfa-89b5-42caea3a9f93@linaro.org>
Date: Tue, 18 Mar 2025 09:09:54 +0200
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Jakub Czapiga <czapiga@...gle.com>
Cc: Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: gigadevice: add lock flags for GD25Q128/256
 and GD25LQ128D



On 17.03.2025 20:20, Jakub Czapiga wrote:
> Set appropriate FLASH lock feature flags.
> Set top-bottom protection configuration bit flags.
> 
> Modified chips:
> - GD25Q128 (+lock, +tb)
> - GD25Q256 (+lock)
> - GD25Q256D, GD25Q256E (+tb)
> - GD25LQ128D (+lock, +tb)
> 
> Signed-off-by: Jakub Czapiga <czapiga@...gle.com>
> ---
>  drivers/mtd/spi-nor/gigadevice.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c
> index ef1edd0add70..8eec6557b036 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -16,6 +16,7 @@ gd25q256_post_bfpt(struct spi_nor *nor,
>  	/*
>  	 * GD25Q256C supports the first version of JESD216 which does not define
>  	 * the Quad Enable methods. Overwrite the default Quad Enable method.
> +	 * Otherwise set TB to SR(6).
>  	 *
>  	 * GD25Q256 GENERATION | SFDP MAJOR VERSION | SFDP MINOR VERSION
>  	 *      GD25Q256C      | SFDP_JESD216_MAJOR | SFDP_JESD216_MINOR
> @@ -25,6 +26,8 @@ gd25q256_post_bfpt(struct spi_nor *nor,
>  	if (bfpt_header->major == SFDP_JESD216_MAJOR &&
>  	    bfpt_header->minor == SFDP_JESD216_MINOR)
>  		nor->params->quad_enable = spi_nor_sr1_bit6_quad_enable;
> +	else
> +		nor->flags |= SNOR_F_HAS_SR_TB | SNOR_F_HAS_SR_TB_BIT6;

why do you tie locking by SFDP absence?