linux-kernel - Re: [PATCH v6 03/13] iomap: rework IOMAP atomic flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c412fcd-12eb-4f91-9c18-5c3373c87573@oracle.com>
Date: Tue, 18 Mar 2025 08:11:00 +0000
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: brauner@...nel.org, djwong@...nel.org, cem@...nel.org, dchinner@...hat.com,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
        ritesh.list@...il.com, martin.petersen@...cle.com, tytso@....edu,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v6 03/13] iomap: rework IOMAP atomic flags

On 18/03/2025 05:32, Christoph Hellwig wrote:
> On Mon, Mar 17, 2025 at 09:05:39AM +0000, John Garry wrote:
>>> Same here (at least for now until it is changed later).
>> Please note that Christian plans on sending the earlier iomap changes
>> related to this work for 6.15. Those changes are also in the xfs queue. We
>> are kinda reverting those changes here, so I think that it would still make
>> sense for the iomap changes in this series to make 6.15
>>
>> The xfs changes in this series are unlikely to make 6.15
>>
>> As such, if we say that ext4 always uses hardware atomics, then we should
>> mention that xfs does also (until it doesn't).
> That's what I meant.

ok

> 
>> So, in the end, I'd rather not add those comments at all - ok?
> If I read through this code it would be kinda nice to figure out why
> we're instructing the iomap code to do it.  If you look at
> xfs_direct_write_iomap_begin it also generally comments on why we
> set specific flags.

understood