linux-kernel - Re: [PATCH v2 3/4] Kbuild: Create intermediate vmlinux build with relocations preserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250318081753.8448Abd-hca@linux.ibm.com>
Date: Tue, 18 Mar 2025 09:17:53 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Ard Biesheuvel <ardb@...nel.org>, kernel test robot <lkp@...el.com>,
        Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-kbuild@...r.kernel.org, x86@...nel.org,
        Ingo Molnar <mingo@...nel.org>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-next@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2 3/4] Kbuild: Create intermediate vmlinux build with
 relocations preserved

On Thu, Mar 13, 2025 at 07:29:41PM +0900, Masahiro Yamada wrote:
> On Thu, Mar 13, 2025 at 7:18 PM Ard Biesheuvel <ardb@...nel.org> wrote:
> > On Thu, 13 Mar 2025 at 10:34, Ard Biesheuvel <ardb@...nel.org> wrote:
> > > On Thu, 13 Mar 2025 at 10:21, kernel test robot <lkp@...el.com> wrote:
> > > > kernel test robot noticed the following build errors:
> > > >
> > > > [auto build test ERROR on masahiroy-kbuild/for-next]
> > > > [also build test ERROR on masahiroy-kbuild/fixes tip/x86/core s390/features linus/master v6.14-rc6 next-20250312]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > > >
> > > > url:    https://github.com/intel-lab-lkp/linux/commits/Ard-Biesheuvel/Kbuild-link-vmlinux-sh-Make-output-file-name-configurable/20250311-190926
> > > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git for-next
> > > > patch link:    https://lore.kernel.org/r/20250311110616.148682-9-ardb%2Bgit%40google.com
> > > > patch subject: [PATCH v2 3/4] Kbuild: Create intermediate vmlinux build with relocations preserved
> > > > config: x86_64-randconfig-076-20250313 (https://download.01.org/0day-ci/archive/20250313/202503131715.Fb6CfjhT-lkp@intel.com/config)
> > > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503131715.Fb6CfjhT-lkp@intel.com/reproduce)
> > > >
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > the same patch/commit), kindly add following tags
> > > > | Reported-by: kernel test robot <lkp@...el.com>
> > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202503131715.Fb6CfjhT-lkp@intel.com/
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > >> gawk: scripts/generate_builtin_ranges.awk:82: fatal: cannot open file `vmlinux.map' for reading: No such file or directory
> > > >
> > >
> > > Hmm it seems I missed some things in link-vmlinux.sh - I will take a look.
> >
> > We'd need something like the below applied on top - shall I send a v3?
> 
> I will insert this before you patch set.
> https://lore.kernel.org/linux-kbuild/20250313102604.1491732-1-masahiroy@kernel.org/T/#u
...
> > --- a/scripts/link-vmlinux.sh
> > +++ b/scripts/link-vmlinux.sh
...
> > -vmlinux_link "${VMLINUX}"
> > +vmlinux_link "${VMLINUX}" vmlinux.map
> >
> >  # fill in BTF IDs
> >  if is_enabled CONFIG_DEBUG_INFO_BTF; then

Building linux-next breaks on s390 with DEBUG_INFO_BTF enabled because
of this; just where your addon patch ends:

  LD      vmlinux.unstripped
  BTFIDS  vmlinux
FAILED cannot open vmlinux: No such file or directory
make[2]: *** [scripts/Makefile.vmlinux:91: vmlinux.unstripped] Error 255
make[2]: *** Deleting file 'vmlinux.unstripped'
make[1]: *** [/home/builder/linux-next/Makefile:1239: vmlinux] Error 2
make: *** [Makefile:248: __sub-make] Error 2

I guess _something_ like below is needed to fix this (works for
me(tm)):

diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 4949d0c8c267..51367c2bfc21 100755
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -286,12 +286,12 @@ vmlinux_link "${VMLINUX}"
 
 # fill in BTF IDs
 if is_enabled CONFIG_DEBUG_INFO_BTF; then
-	info BTFIDS vmlinux
+	info BTFIDS "${VMLINUX}"
 	RESOLVE_BTFIDS_ARGS=""
 	if is_enabled CONFIG_WERROR; then
 		RESOLVE_BTFIDS_ARGS=" --fatal_warnings "
 	fi
-	${RESOLVE_BTFIDS} ${RESOLVE_BTFIDS_ARGS} vmlinux
+	${RESOLVE_BTFIDS} ${RESOLVE_BTFIDS_ARGS} "${VMLINUX}"
 fi
 
 mksysmap "${VMLINUX}" System.map