linux-kernel - Re: [PATCH 1/3] dt-bindings: clock: renesas: Fix description section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9ks/pBQCWXUDO78@duo.ucw.cz>
Date: Tue, 18 Mar 2025 09:21:18 +0100
From: Pavel Machek <pavel@...x.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>,
	tomm.merciai@...il.com, linux-renesas-soc@...r.kernel.org,
	biju.das.jz@...renesas.com, Pavel Machek <pavel@...x.de>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Magnus Damm <magnus.damm@...il.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: renesas: Fix description section

Hi!

> On Mon, 17 Mar 2025 at 09:32, Tommaso Merciai
> <tommaso.merciai.xr@...renesas.com> wrote:
> > Remove not needed "and" into description section.
> >
> > Reported-by: Pavel Machek <pavel@...x.de>
> > Closes: https://lore.kernel.org/cip-dev/Z9P%2F51qOlq2B46FK@duo.ucw.cz/
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,rzv2h-cpg.yaml
> > @@ -12,7 +12,7 @@ maintainers:
> >  description:
> >    On Renesas RZ/{G3E,V2H(P)} SoCs, the CPG (Clock Pulse Generator) handles
> >    generation and control of clock signals for the IP modules, generation and
> > -  control of resets, and control over booting, low power consumption and power
> > +  control of resets, control over booting, low power consumption and power
> >    supply domains.
> >
> >  properties:
> 
> I think the original is fine.  When emphasizing the structure:
> 
>     The CPG handles:
>       A. generation and control of clock signals for the IP modules,
>       B. generation and control of resets, and
>       C. control over booting, low power consumption and power supply domains.
> 
> i.e. the "and" is part of the typical "A, B, and C" construct?

Well, it is still horid sentence. What about making it into list, as
you did?

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)