linux-kernel - Re: [PATCH v2] rust: file: optimize rust symbol generation for FileDescriptorReservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250318-ankommen-entkam-5a89f05374a9@brauner>
Date: Tue, 18 Mar 2025 09:24:30 +0100
From: Christian Brauner <brauner@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Kunwu Chan <kunwu.chan@...ux.dev>, ojeda@...nel.org, 
	alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, a.hindborg@...nel.org, tmgross@...ch.edu, dakr@...nel.org, 
	nathan@...nel.org, nick.desaulniers+lkml@...il.com, morbo@...gle.com, 
	justinstitt@...gle.com, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, Kunwu Chan <kunwu.chan@...mail.com>, 
	Grace Deng <Grace.Deng006@...il.com>
Subject: Re: [PATCH v2] rust: file: optimize rust symbol generation for
 FileDescriptorReservation

On Mon, Mar 17, 2025 at 10:24:15AM +0000, Alice Ryhl wrote:
> Adding Christian Brauner who originally merged the
> rust/kernel/fs/file.rs file.
> 
> On Mon, Mar 17, 2025 at 10:37:02AM +0800, Kunwu Chan wrote:
> > From: Kunwu Chan <kunwu.chan@...mail.com>
> > 
> > When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64
> > with ARCH=arm64, the following symbols are generated:
> > 
> > $ nm vmlinux | grep ' _R'.*FileDescriptorReservation | rustfilt
> > ... T <kernel::fs::file::FileDescriptorReservation>::fd_install
> > ... T <kernel::fs::file::FileDescriptorReservation>::get_unused_fd_flags
> > ... T <kernel::fs::file::FileDescriptorReservation as core::ops::drop::Drop>::drop
> > 
> > These Rust symbols are trivial wrappers around the C functions
> > fd_install, put_unused_fd and put_task_struct. It
> > doesn't make sense to go through a trivial wrapper for these
> > functions, so mark them inline.
> > 
> > Link: https://github.com/Rust-for-Linux/linux/issues/1145
> > Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
> > Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
> > Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
> > Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>
> 
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>

I mentioned various times that anything fs related goes through the VFS
tree, I hope that we're all still aware of this agreement.