linux-kernel - Re: [PATCH v4] fs/proc/page: Refactoring to reduce code duplication.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e48e415-b5db-4555-b73b-d2a032752bfd@redhat.com>
Date: Tue, 18 Mar 2025 09:44:03 +0100
From: David Hildenbrand <david@...hat.com>
To: Liu Ye <liuyerd@....com>, hannes@...xchg.org, mhocko@...nel.org,
 roman.gushchin@...ux.dev, shakeel.butt@...ux.dev, muchun.song@...ux.dev
Cc: akpm@...ux-foundation.org, willy@...radead.org,
 svetly.todorov@...verge.com, vbabka@...e.cz, ran.xiaokai@....com.cn,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-mm@...ck.org, Liu Ye <liuye@...inos.cn>
Subject: Re: [PATCH v4] fs/proc/page: Refactoring to reduce code duplication.

On 18.03.25 07:32, Liu Ye wrote:
> From: Liu Ye <liuye@...inos.cn>
> 
> The function kpageflags_read and kpagecgroup_read is quite similar
> to kpagecount_read. Consider refactoring common code into a helper
> function to reduce code duplication.
> 
> Signed-off-by: Liu Ye <liuye@...inos.cn>
> 
> ---
> V4 : Update code remake patch.
> V3 : Add a stub for page_cgroup_ino and remove the #ifdef CONFIG_MEMCG.
> V2 : Use an enumeration to indicate the operation to be performed
> to avoid passing functions.
> ---

Acked-by: David Hildenbrand <david@...hat.com>

Thanks!

-- 
Cheers,

David / dhildenb