linux-kernel - Re: [PATCH RFC v3 2/3] firmware: mediatek: Add vcp ipc protocol interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12f5049d-02e1-4c80-9289-b2dfb1e136a8@kernel.org>
Date: Tue, 18 Mar 2025 10:00:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jjian Zhou (周建) <Jjian.Zhou@...iatek.com>,
 "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "wenst@...omium.org" <wenst@...omium.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH RFC v3 2/3] firmware: mediatek: Add vcp ipc protocol
 interface

On 18/03/2025 09:32, Jjian Zhou (周建) wrote:
>>> +
>>> +     return IPI_ACTION_DONE;
>>> +}
>>> +EXPORT_SYMBOL(mtk_vcp_ipc_send);
>>
>> Drop export - no users
>>
>> Anyway, every export must be GPL.
> 
> The Video Companion Processor (VCP) driver (currently being prepared
> for submission to the community) will call it.
> 

It does not work like that. You must post the users NOW.

NAK


...

>> Check goes immediately after declaration. I doubt it is useful in the
>> first place as this cannot even happen...
>>
>>
>>> +             dev_err(dev, "No platform data available\n");
>>
>> No, drop. Cannot happen or fix your drivers. Who provides the
>> platdata here?
> 
> The VCP driver will call platform_device_register_data to register the
> structure data. mtk_vcp_ipc_probe will be triggered by vcp_probe. This
> structure data is the structure we described in the cover letter.


Comment is still valid.

Best regards,
Krzysztof