linux-kernel - Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11435166-28bc-432b-9b2b-d6bff586c882@ixit.cz>
Date: Tue, 18 Mar 2025 10:07:22 +0100
From: David Heidelberg <david@...t.cz>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andy Gross <agross@...nel.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: soc: qcom,wcnss: Document local-mac-address

On 18/03/2025 09:49, Krzysztof Kozlowski wrote:
> On Mon, Mar 17, 2025 at 09:26:05PM +0100, David Heidelberg wrote:
>> The device and driver do support setting a custom MAC address.
>>
>> Fixes: c49e9e95f4d1 ("dt: binding: Add Qualcomm WCNSS control binding")
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> index fd6db0ca98eb7e56d7399f55c408844d5e782805..6938dc4ccc2175a65f6f53c6d073fb72cf498b2c 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
>> @@ -68,6 +68,8 @@ properties:
>>             - const: tx
>>             - const: rx
>>   
>> +      local-mac-address: true
> 
> Which referenced binding provides the definition of this property (its
> type)? AFAIK, that's not a property of Wifi nodes.

Good catch!

Would you find reasonable to add the property to  wireless/ieee80211.yaml ?

I feel like this could be "shared" between ethernet and ieee80211, but 
have it twice in these two sounds acceptable to me.

Thanks

> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg