linux-kernel - Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6760518ea9e65ec5d1a18861f88e0a758e0f3fa6.camel@kernel.org>
Date: Tue, 18 Mar 2025 10:51:58 +0100
From: Amit Shah <amit@...nel.org>
To: Maximilian Immanuel Brandtner <maxbr@...ux.ibm.com>, Niklas Schnelle
	 <schnelle@...ux.ibm.com>, linux-kernel@...r.kernel.org, 
	virtualization@...ts.linux.dev
Cc: arnd@...db.de, gregkh@...uxfoundation.org, brueckner@...ux.ibm.com, 
	pasic@...ux.ibm.com
Subject: Re: [PATCH] virtio: console: Make resizing compliant with virtio
 spec

On Mon, 2025-03-10 at 14:04 +0100, Maximilian Immanuel Brandtner wrote:

[...]

> Just to make sure that everyone here is one the same page there is
> indeed a difference between the ordering of the control resize
> message
> and the kernel implementation; however as this bug has been around
> for
> ~15 years the spec should be changed instead, right?
> 
> I would like to get a clear ACK of the issue, as I would like to
> reference this discussion when creating a bug-report on the virtio-
> spec
> github.

I'm afraid you haven't understood the difference between a control
message for an individual port, and the config space for the entire
device.  Please re-read my post earlier in the thread, and follow the
code.  There's no divergence in the implementation and the spec, and
there's nothing to fix.  If anything, there may be a chance to add to
the spec the order for the control message - though I don't think
there's a strong need to.

		Amit