linux-kernel - Re: [RFC PATCH 2/3] tpm/tpm_ftpm_tee: use send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5tgxiza47d3md5epw32exddl3wm5pkc3ja76dkex5jwxpmcnj@c27hnr4ezido>
Date: Tue, 18 Mar 2025 11:55:16 +0100
From: Stefano Garzarella <sgarzare@...hat.com>
To: Jens Wiklander <jens.wiklander@...aro.org>, 
	Sumit Garg <sumit.garg@...nel.org>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, linux-integrity@...r.kernel.org, 
	linux-kernel@...r.kernel.org, James Bottomley <James.Bottomley@...senpartnership.com>, 
	Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [RFC PATCH 2/3] tpm/tpm_ftpm_tee: use send_recv() op

Hi Sumit, Jens,

On Thu, Mar 13, 2025 at 01:59:19PM +0100, Jens Wiklander wrote:
>On Thu, Mar 13, 2025 at 10:13 AM Sumit Garg <sumit.garg@...nel.org> 
>wrote:
>>
>> + Jens
>>
>> Hi Stefano,
>>
>> On Tue, Mar 11, 2025 at 11:01:29AM +0100, Stefano Garzarella wrote:
>> > This driver does not support interrupts, and receiving the response is
>> > synchronous with sending the command.
>> >
>> > It used an internal buffer to cache the response when .send() is called,
>> > and then return it when .recv() is called.
>> >
>> > Let's simplify the driver by implementing the new send_recv() op, so that
>> > we can also remove the 4KB internal buffer used to cache the response.
>>
>> Looks like a nice cleanup to me but it needs to be tested. Jens, can you
>> give this patch a try?
>>
>> >
>> > Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
>> > ---
>> > Note: I don't know how to test this driver, so I just build it.
>> > If someone can test it, or tell me how to do, it will be great!
>
>Tested-by: Jens Wiklander <jens.wiklander@...aro.org>
>

Thanks for testing this!

>Cheers,
>Jens
>
>>
>> The fTPM is now maintained as part of OP-TEE project here [1]. The
>> instructions to test it on Qemu can be found here [2] as part of CI
>> pipeline.
>>
>> [1] https://github.com/OP-TEE/optee_ftpm
>> [2] https://github.com/OP-TEE/optee_ftpm/blob/master/.github/workflows/ci.yml
>>

Thanks for the links, I'll take a look!

Stefano