[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<SEYPR06MB5134A69692C6C474BDE9A6A99DDE2@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 18 Mar 2025 11:00:27 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "ratbert@...aday-tech.com"
<ratbert@...aday-tech.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject:
回覆: [net-next 2/4] ARM: dts: ast2600-evb: add default RGMII delay
Hi Andrew,
Thank you for your reply.
> > phy-mode = "rgmii";
> > phy-handle = <ðphy2>;
> >
> > + tx-internal-delay-ps = <8>;
> > + rx-internal-delay-ps = <4>;
> > +
>
> Ideally you want:
>
> phy-mode = "rgmii-id";
> tx-internal-delay-ps = <0>;
> rx-internal-delay-ps = <0>;
>
> Since 'rgmii-id' correctly describes the hardware.
I still confuse about ethernet-controller.yaml.
It lists 'rgmi', 'rgmii-rxid', 'rgmii-txid' and 'rgmii-id'.
ethernet-controller.yaml
...
# RX and TX delays are added by the MAC when required
- rgmii
# RGMII with internal RX and TX delays provided by the PHY,
# the MAC should not add the RX or TX delays in this case
- rgmii-id
# RGMII with internal RX delay provided by the PHY, the MAC
# should not add an RX delay in this case
- rgmii-rxid
# RGMII with internal TX delay provided by the PHY, the MAC
# should not add an TX delay in this case
- rgmii-txid
...
It seems if MAC has ability to add delay in MAC internal, driver can use these
values to describes the hardware design.
I know this topic had been discussed. I thought for a while to find a solution, but I
cannot still understand why 'rgmii-id' is correct for HW?
Thanks,
Jacky
Powered by blists - more mailing lists