linux-kernel - Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2481243.1742296198@warthog.procyon.org.uk>
Date: Tue, 18 Mar 2025 11:09:58 +0000
From: David Howells <dhowells@...hat.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Marc Dionne <marc.dionne@...istor.com>,
    Jakub Kicinski <kuba@...nel.org>,
    "David
 S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    Simon Horman <horms@...nel.org>,
    Trond Myklebust <trond.myklebust@...merspace.com>,
    Chuck Lever <chuck.lever@...cle.com>,
    Eric Biggers <ebiggers@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
    linux-crypto@...r.kernel.org, linux-afs@...ts.infradead.org,
    linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm

Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> > +         Combined hash and cipher support for Kerberos 5 RFC3961 simplified
> > +         profile.  This is required for Kerberos 5-style encryption, used by
> > +         sunrpc/NFS and rxrpc/AFS.
> 
> Hence shouldn't the latter (e.g. RPCSEC_GSS_KRB5) select CRYPTO_KRB5ENC
> or CRYPTO_KRB5? Or am I missing something?

SunRPC hasn't been converted to use it yet.  The help text is slightly
misleading, I guess: "Kerberos 5-style encryption" is used by sunrpc/NFS
within the kernel, but not this library yet.

Unfortunately, the rxrpc/AFS patches didn't make it in due to them requiring
to go through the net-next tree, but having dependencies on both the VFS tree
and the crypto tree.

Herbert wanted the crypto patches (krb5 lib) based on his tree, which I did
and he pulled it - but then this disqualified it for also being pulled into
net-next as that would've pulled *all* the crypodev patches there as well.

For reference, the rxrpc patches can be found here:

	https://web.git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next

I intend to post them for net-next inclusion after the merge window.

David