linux-kernel - [PATCH] scsi: gvp11: Fix error path after scsi_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250318130532.11546-1-linmq006@gmail.com>
Date: Tue, 18 Mar 2025 21:05:31 +0800
From: Miaoqian Lin <linmq006@...il.com>
To: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Hyunchul Lee <hyc.lee@...il.com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Ronnie Sahlberg <lsahlber@...hat.com>,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Steve French <stfrench@...rosoft.com>,
	linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: linmq006@...il.com
Subject: [PATCH] scsi: gvp11: Fix error path after scsi_host_alloc

Fix error path after scsi_host_alloc() by using fail_irq label instead of
fail_check_or_alloc when dma_set_mask_and_coherent() fails. This ensures
proper cleanup of allocated resources by calling scsi_host_put().

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 drivers/scsi/gvp11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/gvp11.c b/drivers/scsi/gvp11.c
index 0420bfe9bd42..272ea2d1c8fd 100644
--- a/drivers/scsi/gvp11.c
+++ b/drivers/scsi/gvp11.c
@@ -381,7 +381,7 @@ static int gvp11_probe(struct zorro_dev *z, const struct zorro_device_id *ent)
 			dev_warn(&z->dev, "cannot use DMA mask %llx\n",
 				 TO_DMA_MASK(gvp11_xfer_mask));
 			error = -ENODEV;
-			goto fail_check_or_alloc;
+			goto fail_irq;
 		}
 	} else
 		hdata->wh.dma_xfer_mask = default_dma_xfer_mask;
-- 
2.39.5 (Apple Git-154)